Re: [PATCH] mmc: sdhci-pxav3: fix error handling of sdhci_add_host

From: Laurent Pinchart
Date: Wed Jul 16 2014 - 05:53:30 EST


Hi Xiang,

Thank you for the patch.

On Wednesday 16 July 2014 15:50:09 Xiang Wang wrote:
> From: Xiang Wang <wangx@xxxxxxxxxxx>
>
> Commit 0dcaa2499b7d111bd70da5b0976c34210c850fb3 improved error
> handling of sdhci_add_host. However, "err_of_parse" and "err_cd_req"
> should be placed after "pm_runtime_disable(&pdev->dev)".
>
> Signed-off-by: Xiang Wang <wangx@xxxxxxxxxxx>

Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

While we're touching the probe error path, how about converting the driver to
the devm_* helpers ? I'll send a patch shortly.

> ---
> drivers/mmc/host/sdhci-pxav3.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
> index 2fd73b3..0644655 100644
> --- a/drivers/mmc/host/sdhci-pxav3.c
> +++ b/drivers/mmc/host/sdhci-pxav3.c
> @@ -380,11 +380,11 @@ static int sdhci_pxav3_probe(struct platform_device
> *pdev)
>
> return 0;
>
> -err_of_parse:
> -err_cd_req:
> err_add_host:
> pm_runtime_put_sync(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> +err_of_parse:
> +err_cd_req:
> clk_disable_unprepare(clk);
> clk_put(clk);
> err_clk_get:

--
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/