Scheduler regression from caffcdd8d27ba78730d5540396ce72ad022aff2c

From: Bruno Wolff III
Date: Wed Jul 16 2014 - 10:57:23 EST


caffcdd8d27ba78730d5540396ce72ad022aff2c has been causing crashes early in the boot process on one of three machines I have been testing the kernel on. On that one machine it happens every boot. It happens before netconsole is functional.

A partial revert of the commit fixes the problem. I do not know why the commit is broken though.

I have filed https://bugzilla.kernel.org/show_bug.cgi?id=80251 for this issue.

The problem happens on both Fedora and Linus kernels.

git diff caffcdd8d27ba78730d5540396ce72ad022aff2c^ caffcdd8d27ba78730d5540396ce72ad022aff2c
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 45d077ed24fb..6340c601475d 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5794,8 +5794,6 @@ build_sched_groups(struct sched_domain *sd, int cpu)
continue;

group = get_group(i, sdd, &sg);
- cpumask_clear(sched_group_cpus(sg));
- sg->sgp->power = 0;
cpumask_setall(sched_group_mask(sg));

for_each_cpu(j, span) {

By rc5 the second line can't be added back because the structure has changed. However adding back cpumask_clear(sched_group_cpus(sg)); to rc5 got things working for me again.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/