Re: [PATCH] fs/direct-io.c: Fix compilation warning for uninitialized variables

[Christoph Hellwig]

On Wed, Jul 16, 2014 at 08:08:41PM +0300, Boaz Harrosh wrote:
> This is the wrong fix. GCC is wrong here. As shown by Paul Bolle if
> you move the from / to set from dio_get_page() to here the warning goes away.
> 
> The minimal fix must use uninitialized_var() in this case. See patch below
> 
> But I think the proper fix Is the one Paul Bolle <pebolle@xxxxxxxxxx> sent (above)

I don't think the initialization is wrong.  The fix of moving the code
defintively looks nicer, while I think uninitialized_var is horrible
wart that won't get anywhere near my code.

Either way we should merge one of those fixes ASAP..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/