Re: [PATCH v4 1/3] soc: devicetree: bindings: Add Qualcomm RPM DT binding

From: Bjorn Andersson
Date: Wed Jul 16 2014 - 18:20:48 EST


On Wed, Jul 16, 2014 at 3:06 AM, pramod gurav
<pramod.gurav.etc@xxxxxxxxx> wrote:
> Hi Bjorn,
>
> RPM breaks on IFC6410 without entry for 'qcom.ipc' node. Please find
> my observations below.
>
> On Wed, Jul 16, 2014 at 4:30 AM, Bjorn Andersson
> <bjorn.andersson@xxxxxxxxxxxxxx> wrote:
[...]
>> + rpm@108000 {
>> + compatible = "qcom,rpm-msm8960";
>> + reg = <0x108000 0x1000>;
>> + qcom,ipc = <&apcs 0x8 2>;
>
> Tried adding this but there is no reference to 'apcs' registers itself
> in any dts.
>
> Without these changes rpm breaks hence not able to test SATA which needs rpm.
>

Hi Pramod,

Unfortunately the ipc bits resides in a block that needs to be
accesses by various device drivers so I had to extract the access; so
you now need to reference it via a syscon handle and offset instead -
as described above.

The apcs node I used for testing this with looks like this:

apcs: syscon@2011000 {
compatible = "syscon";
reg = <0x2011000 0x1000>;
};

Enable CONFIG_MFD_SYSCON and put the dt snippet somewhere under soc
and you should be good.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/