Re: [PATCH] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

From: Saravana Kannan
Date: Wed Jul 16 2014 - 18:35:35 EST


On 07/16/2014 03:02 PM, Rafael J. Wysocki wrote:
On Wednesday, July 09, 2014 07:37:30 PM Saravana Kannan wrote:
Preliminary patch. Not tested. Just sending out to give an idea of what I'm
looking to do. Expect a lot more simplification when it's done.

Benefits:
* A lot more simpler code.
* Less stability issues.
* Suspend/resume time would improve.
* Hotplug time would improve.
* Sysfs file permissions would be maintained.
* More policy settings would be maintained across suspend/resume.
* cpufreq stats would be maintained across hotplug for all CPUs.

One problem. The real hotplug (when the CPU actually goes away) depends on
offline removing all that stuff for it. How are you going to address that?

policy, sysfs and kobj are just SW state inside cpufreq core. So, that shouldn't really affect what happens in HW when the CPU really is hotplugged. Can you please elaborate what you mean?

The only thing that this code assumes is that in real hotplug case too, that the /sys/system/devices/cpuX directory doesn't go away. I don't think it does. Does it?

-Saravana

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/