Re: [PATCH 2/3] rcu: Remove stale comment in tree.c

[josh]

On Wed, Jul 16, 2014 at 09:29:18AM -0400, Pranith Kumar wrote:
> On 07/16/2014 08:47 AM, Paul E. McKenney wrote:
> > On Tue, Jul 15, 2014 at 06:57:59PM -0400, Pranith Kumar wrote:
> >>
> >> On 07/15/2014 06:53 PM, josh@xxxxxxxxxxxxxxxx wrote:
> >>> On Tue, Jul 15, 2014 at 06:31:48PM -0400, Pranith Kumar wrote:
> >>>> This commit removes a stale comment in rcu/tree.c.
> >>>> FYI, an updated comment exists a few lines below this.
> >>>>
> >>>> Signed-off-by: Pranith Kumar <bobby.prani@xxxxxxxxx>
> >>> In general, when removing a stale comment, I'd suggest explaining why
> >>> the comment is stale.  Was code removed without removing the
> >>> corresponding comment, or was code changed such that the comment no
> >>> longer applies, or...?
> >>
> >> I guess it was left out when code was moved around previously. And I did mention that an updated comment is there a few lines below.
> >>
> >> For reference this is the new comment which is below the old comment, they mean the same :)
> >>
> >>     /* Remove the outgoing CPU from the masks in the rcu_node hierarchy. */
> > 
> > Indeed that is the case.
> > 
> > Please update the commit log with this explanation and resend.
> > 
> > 								Thanx, Paul
> > 
> 
> Please find the updated patch below.
> 
> --
> Pranith
> 
> From: Pranith Kumar <bobby.prani@xxxxxxxxx>
> Date: Mon, 14 Jul 2014 16:01:05 -0400
> Subject: [PATCH 2/3] rcu: Remove stale comment in tree.c
> 
> This commit removes a stale comment in rcu/tree.c which was left out when some
> code was moved around previously.
> 
> For reference, the following updated comment exists a few lines below this which
> means the same.
> 
> /* Remove the outgoing CPU from the masks in the rcu_node hierarchy. */
> 
> Signed-off-by: Pranith Kumar <bobby.prani@xxxxxxxxx>

Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

>  kernel/rcu/tree.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index a1abaa8..e67246e 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2211,8 +2211,6 @@ static void rcu_cleanup_dead_cpu(int cpu, struct rcu_state *rsp)
>  	/* Adjust any no-longer-needed kthreads. */
>  	rcu_boost_kthread_setaffinity(rnp, -1);
>  
> -	/* Remove the dead CPU from the bitmasks in the rcu_node hierarchy. */
> -
>  	/* Exclude any attempts to start a new grace period. */
>  	mutex_lock(&rsp->onoff_mutex);
>  	raw_spin_lock_irqsave(&rsp->orphan_lock, flags);
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/