Re: [PATCH 2/3] rcu: Remove stale comment in tree.c

From: Josh Triplett
Date: Wed Jul 16 2014 - 22:14:22 EST


On Wed, Jul 16, 2014 at 09:01:52PM -0400, Pranith Kumar wrote:
> Sure, please find an updated patch with Josh Triplett's sign-off added:

It appears to have a reviewed-by from someone named "Joe Tripplett"
instead. ;)

> From: Pranith Kumar <bobby.prani@xxxxxxxxx>
> Date: Mon, 14 Jul 2014 16:01:05 -0400
> Subject: [PATCH 2/3] rcu: Remove stale comment in tree.c
>
>
> This commit removes a stale comment in rcu/tree.c which was left out in
> commit 2036d94a7b61ca5032ce (rcu: Rework detection of use of RCU by offline CPUs)
>
> For reference, the following updated comment exists a few lines below this which
> means the same.
>
> /* Remove the outgoing CPU from the masks in the rcu_node hierarchy. */
>
> Signed-off-by: Pranith Kumar <bobby.prani@xxxxxxxxx>
> Reviewed-by: Joe Tripplett <josh@xxxxxxxxxxxxxxxx>
> ---
> kernel/rcu/tree.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index a1abaa8..e67246e 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2211,8 +2211,6 @@ static void rcu_cleanup_dead_cpu(int cpu, struct rcu_state *rsp)
> /* Adjust any no-longer-needed kthreads. */
> rcu_boost_kthread_setaffinity(rnp, -1);
>
> - /* Remove the dead CPU from the bitmasks in the rcu_node hierarchy. */
> -
> /* Exclude any attempts to start a new grace period. */
> mutex_lock(&rsp->onoff_mutex);
> raw_spin_lock_irqsave(&rsp->orphan_lock, flags);
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/