Re: [PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

[Oded Gabbay]

On 11/07/14 20:28, Joe Perches wrote:
> On Fri, 2014-07-11 at 13:04 -0400, Jerome Glisse wrote:
> > On Fri, Jul 11, 2014 at 12:50:09AM +0300, Oded Gabbay wrote:
> []
> > > +static long kfd_ioctl(struct file *, unsigned int, unsigned long);
> >
> > Nitpick, avoid unsigned int just use unsigned.
>
> I suggest unsigned int is much more common (and better)
> than just unsigned.
>
> $ git grep -P '\bunsigned\s+(?!long|int|short|char)' -- "*.[ch]" | wc -l
> 20778
>
> $ git grep -P "\bunsigned\s+int\b" -- "*.[ch]" | wc -l
> 98068
So I left it as unsigned int in v2 of the patchset.

> > > +static int kfd_open(struct inode *, struct file *);
>
> It's also generally better to use types and names tno
> improve how a human reads and understands the code.
Fixed in v2 of the patchset.

	Oded

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/