Re: [patch V2 64/64] ftrace: Provide trace clocks monotonic

[Steven Rostedt]

On Wed, 16 Jul 2014 21:05:25 -0000
Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> Expose the new NMI safe accessor to clock monotonic to the tracer.
> 
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
> ---
>  kernel/trace/trace.c |   11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> Index: tip/kernel/trace/trace.c
> ===================================================================
> --- tip.orig/kernel/trace/trace.c
> +++ tip/kernel/trace/trace.c
> @@ -806,11 +806,12 @@ static struct {
>  	const char *name;
>  	int in_ns;		/* is this clock in nanoseconds? */
>  } trace_clocks[] = {
> -	{ trace_clock_local,	"local",	1 },
> -	{ trace_clock_global,	"global",	1 },
> -	{ trace_clock_counter,	"counter",	0 },
> -	{ trace_clock_jiffies,	"uptime",	1 },
> -	{ trace_clock,		"perf",		1 },
> +	{ trace_clock_local,		"local",	1 },
> +	{ trace_clock_global,		"global",	1 },
> +	{ trace_clock_counter,		"counter",	0 },
> +	{ trace_clock_jiffies,		"uptime",	1 },
> +	{ trace_clock,			"perf",		1 },
> +	{ ktime_get_mono_fast_ns,	"mono",		1 },

I'm not sure I like the name "mono" because all the clocks listed are
considered monolithic (with the view of tracing). What about calling it
"user" as I believe this clock is the one that will be used to
synchronize userspace times with the kernel. Right?

-- Steve

>  	ARCH_TRACE_CLOCKS
>  };
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/