Re: [PATCH] staging: llite: rw.c: use gfp_t to store GFP flags

From: Greg KH
Date: Mon Jul 21 2014 - 22:08:13 EST


On Tue, Jul 22, 2014 at 02:57:57AM +0200, Guillaume Morin wrote:
> Use gfp_t to store GPF_* flags instead of unsigned int.
> This was reported by sparse.
>
> Signed-off-by: Guillaume Morin <guillaume@xxxxxxxxxxx>
> ---
> drivers/staging/lustre/lustre/llite/rw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/rw.c b/drivers/staging/lustre/lustre/llite/rw.c
> index 5616210..3554272 100644
> --- a/drivers/staging/lustre/lustre/llite/rw.c
> +++ b/drivers/staging/lustre/lustre/llite/rw.c
> @@ -496,7 +496,7 @@ static int ll_read_ahead_page(const struct lu_env *env, struct cl_io *io,
> struct cl_object *clob = ll_i2info(mapping->host)->lli_clob;
> struct cl_page *page;
> enum ra_stat which = _NR_RA_STAT; /* keep gcc happy */
> - unsigned int gfp_mask;
> + gfp_t gfp_mask;

Odd thing is, that function doesn't seem to even use that variable
anywhere... Can you just remove it entirely?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/