Re: [PATCH] blk-mq: bitmap tag: fix potential unwakeable sleep in bt_get()

From: Alexander Gordeev
Date: Tue Jul 22 2014 - 04:26:45 EST


On Mon, Jul 21, 2014 at 11:11:44AM +0200, Alexander Gordeev wrote:
> > My bad, was looking at the wrong sources. What is the race? If the
> > clear and wakeup come in after the prepare_to_wait() but before the
> > io_schedule(), the io_schedule() will be a no-op and it wont
> > actually sleep. Your commit message doesn't mention any particular
> > details.
>
> Let me examine the code.. It was few weeks ago and I can not
> remember what was that. And the changelog does not help :)

Jens,

I can not recall what was my concern. Sorry for the noise.

Thanks!

> > --
> > Jens Axboe
> >

--
Regards,
Alexander Gordeev
agordeev@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/