Re: [PATCH 0/2] ARM: DRA7: hwmod: Add dra74x and dra72x specific ocp interface lists

From: Nishanth Menon
Date: Tue Jul 22 2014 - 12:46:12 EST


On 07/16/2014 03:36 AM, Lokesh Vutla wrote:
> This series add seperate ocp interface lists that are specific to dra74x
> and dra72x, and moving USB OTG SS4 to dra74x only since its not present
> in dra72x. Without this USB OTG SS4 hwmod gives an abort on dra72x.
>
> Adding support for soc_is_dra74x() and soc_is_dra72x() in order to differentiate
> between dra74x and dra72x and pass the respective ocp interface lists.
>
> Verified on dra74x evm and dra72x evm using 3.16-rc5 based mainline kernel.
>
> Before:
> dra74x : http://paste.ubuntu.com/7802364/
> dra72x : http://paste.ubuntu.com/7802334/ (Kernel panic)
>
> After-
> dra74x : http://paste.ubuntu.com/7802340/
> dra72x : http://paste.ubuntu.com/7802338/ (booted)
>
> Rajendra Nayak (2):
> ARM: DRA7: Add support for soc_is_dra74x() and soc_is_dra72x()
> varients
> ARM: DRA7: hwmod: Add dra74x and dra72x specific ocp interface lists
>
> arch/arm/mach-omap2/omap_hwmod.c | 3 +++
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 22 ++++++++++++++++++++--
> arch/arm/mach-omap2/soc.h | 7 +++++++
> 3 files changed, 30 insertions(+), 2 deletions(-)
>
Tested-by: Nishanth Menon <nm@xxxxxx>

BUT, I suggest a follow up series to do exactly the same (moving stuff
that are not common from dra7.dtsi to dra72x.dtsi and 74x.dtsi) as
well to ensure that dts indicates exactly the same information (only
the applicable IPs are present in dts).

--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/