Re: [PATCH] cleanup include/asm-generic/atomic.h

From: David Rientjes
Date: Tue Jul 22 2014 - 18:17:14 EST


On Tue, 22 Jul 2014, Madhavan Srinivasan wrote:

> On Tuesday 22 July 2014 05:38 AM, David Rientjes wrote:
> > On Tue, 22 Jul 2014, Madhavan Srinivasan wrote:
> >
> >> Commit 4b358e2206 "cleanup include/asm-generic/atomic.h" added
> >> comments for #else/#endif, but ended up adding same comment
> >> "BITS_PER_LONG == 64" on both sides. This patch fixes it.
> >>
> >
> > It's intentionally like that, it comments the condition for which the
> > #endif is matched.
>
> Ok, will change the else comment. And include/asm-generic/local64.h
> also needs a change in comment.
>

The #else comment is fine, it's correct as written. The only use of these
comments is to identify for the reader the #ifdef for which it is matched
when there at least one nested #ifdef.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/