Re: [PATCH] regulator: drivers: fix return value of get_mode callback

From: Laxman Dewangan
Date: Thu Jul 24 2014 - 06:30:04 EST

Hi Mark
On Monday 14 July 2014 11:31 PM, Mark Brown wrote:
* PGP Signed by an unknown key

On Mon, Jul 14, 2014 at 12:57:18PM +0100, Charles Keepax wrote:
On Mon, Jul 14, 2014 at 04:03:17PM +0530, Laxman Dewangan wrote:
It's because it's returning something defined as a bitmask, though since
we don't even have enough modes for 8 bits that's not really a strong
reason and we should just be returning an error code as everyone is
clearly already assuming we do.

Just to confirm, do you want to change the return type of get_mode() to "int" instead of
unsigned int? And then return proper error type?

In this case I think it should be single patch (core + driver).

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at