Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests
From: Martin K. Petersen
Date: Thu Jul 24 2014 - 09:55:34 EST
>>>>> "Sitsofe" == Sitsofe Wheeler <sitsofe@xxxxxxxxx> writes:
Sitsofe> Fix incorrectly named variable. Some block devices (such as
Sitsofe> Hyper-V passthrough SSDs) support logical block provisioning
Sitsofe> (e.g. via UNMAP) but don't set lbpme thus disabling discard.
The fix for an SSD that is known to support LBP but which does not claim
support for it is to use:
echo unmap > /sys/class/scsi_disk/foo/provisioning_mode
I'm very much against short-circuiting the LBP logic in a passthrough
driver because then we might end up in the exact situation we were
trying to avoid with this patch series. Namely sending down commands
unsupported by the target device.
This kind of thing really needs to be a sysadmin decision and can be
handled with a udev rule.
Martin K. Petersen Oracle Linux Engineering
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/