Re: [PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o

[Sam Ravnborg]

On Thu, Jul 24, 2014 at 04:24:48PM +0200, Ard Biesheuvel wrote:
> On 24 July 2014 16:18, Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote:
> > On 24 July 2014 15:40, Andreas Schwab <schwab@xxxxxxx> wrote:
> >> Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> writes:
> >>
> >>> On 24 July 2014 15:26, Andreas Schwab <schwab@xxxxxxx> wrote:
> >>>> You are not using CONFIG_MODVERSIONS.
> >>>>
> >>>
> >>> I am
> >>
> >> No, you aren't, since you say that your .cmd contains a command to
> >> create aes-glue-ce.o, which with CONFIG_MODVERSIONS it doesn't.
> >>
> >
> > OK, you're right, it contains a command to create .tmp_aes-glue-ce.o.
> > But I am still not seeing the error you are seeing, strangely enough.
> 
> OK, now I am seeing it.
> 
> Acked-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>

Jumping in the end of the thread here - sorry for that.

Another way to solve this would be to create two
small wrapper files:
aes-glue-neon.c - which include aes-glue.c
aes-glue-ce.c that include aes-glue.c

Then you could use standard kbuild support for building your module.
And we will not potentially break it when we change cc_o_c in the near future.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/