Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

[Alexei Starovoitov]

On Thu, Jul 24, 2014 at 4:45 PM,  <Valdis.Kletnieks@xxxxxx> wrote:
> On Tue, 22 Jul 2014 23:01:58 -0700, Alexei Starovoitov said:
>> BPF is used in several kernel components. This split creates logical boundary
>> between generic eBPF core and the rest
>>
>> kernel/bpf/core.c: eBPF interpreter
>>
>> net/core/filter.c: classic->eBPF converter, classic verifiers, socket filters
>>
>> This patch only moves functions.
>>
>> Signed-off-by: Alexei Starovoitov <ast@xxxxxxxxxxxx>
>> ---
>>  kernel/Makefile     |    1 +
>>  kernel/bpf/Makefile |    1 +
>>  kernel/bpf/core.c   |  536 +++++++++++++++++++++++++++++++++++++++++++++++++
> ++
>>  net/core/filter.c   |  511 ------------------------------------------------
>>  4 files changed, 538 insertions(+), 511 deletions(-)
>>  create mode 100644 kernel/bpf/Makefile
>>  create mode 100644 kernel/bpf/core.c
>>
>> diff --git a/kernel/Makefile b/kernel/Makefile
>> index f2a8b6246ce9..e7360b7c2c0e 100644
>> --- a/kernel/Makefile
>> +++ b/kernel/Makefile
>> @@ -87,6 +87,7 @@ obj-$(CONFIG_RING_BUFFER) += trace/
>>  obj-$(CONFIG_TRACEPOINTS) += trace/
>>  obj-$(CONFIG_IRQ_WORK) += irq_work.o
>>  obj-$(CONFIG_CPU_PM) += cpu_pm.o
>> +obj-$(CONFIG_NET) += bpf/
>
> I was expecting to see CONFIG_NETFILTER here.  Is CONFIG_NET intentional?

yes. it is config_net for now, until eBPF is completely separate from net.
Then it will gain its own config_bpf, so it can be used in net-less setups
or disabled in net-full setups by folks who care about last byte of .text size.
Future will tell.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/