Re: [PATCH] extcon: Add missing REGMAP_I2C/REGMAP_IRQ dependency on extcon driver

From: Charles Keepax
Date: Fri Jul 25 2014 - 04:39:58 EST


On Wed, Jul 23, 2014 at 10:40:40AM +0900, Chanwoo Choi wrote:
> This patch add missing REGMAP_I2C/REGMAP_IRQ dependency on extcon provider
> driver to protect build break.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> ---
> drivers/extcon/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 6f2f472..77577db 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -23,6 +23,7 @@ config EXTCON_ADC_JACK
> config EXTCON_ARIZONA
> tristate "Wolfson Arizona EXTCON support"
> depends on MFD_ARIZONA && INPUT && SND_SOC
> + select REGMAP_I2C
> help
> Say Y here to enable support for external accessory detection
> with Wolfson Arizona devices. These are audio CODECs with

Could you be more specific about the config that causes the build
break? This seems problematic as REGMAP_I2C is only a dependancy
if I2C is being used otherwise REGMAP_SPI would be the
dependancy.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/