Re: [PATCH] nfs3_list_one_acl(): check get_acl() result with IS_ERR_OR_NULL

From: Christoph Hellwig
Date: Sun Jul 27 2014 - 15:51:03 EST

On Sun, Jul 27, 2014 at 11:13:50AM -0400, Trond Myklebust wrote:
> Why are we not passing the error code back to the caller here in the
> case where we have one? One of the main purposes of returning an error
> in get_acl() is to ensure that we pass -EOPNOTSUPP if the operation
> fails due to lack of server support.

Do we really want to return EOPNOTSUPP from listxattr? Seems like
simply not listing anything if the server doesn't support ACLs would
be the usual behaviour. E.g. on local filesystems we'll also just get
back an empty list of xattrs if ACLs aren't supported and not other
attribute is set.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at