Re: [RFC PATCH v1 14/70] x86, microcode, core: _FROZEN Cleanup

[Chen, Gong]

On Thu, Jul 24, 2014 at 11:03:03AM +0200, Borislav Petkov wrote:
> 
> Missing "break". We like to add those even if it doesn't matter in this
> case.
> 
> Also, add the boilerplate
> 
> "default:
> 	break;"
> 
> while you're at it, please.
> 

--------8<--------
Subject: [RFC PATCH v2 14/70] x86, microcode, core: _FROZEN Cleanup

Remove XXX_FROZEN state from x86/microcode/core.

Signed-off-by: Chen, Gong <gong.chen@xxxxxxxxxxxxxxx>
Suggested-by: Borislav Petkov <bp@xxxxxxxxx>
---
 arch/x86/kernel/cpu/microcode/core.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
index dd9d619..da3c2206 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -499,6 +499,11 @@ mc_cpu_callback(struct notifier_block *nb, unsigned long action, void *hcpu)
 		pr_debug("CPU%d removed\n", cpu);
 		break;
 
+	case CPU_UP_CANCELED:
+		/* The CPU refused to come up during a system resume */
+		if (action & CPU_TASKS_FROZEN)
+			microcode_fini_cpu(cpu);
+		break;
 	/*
 	 * case CPU_DEAD:
 	 *
@@ -507,12 +512,10 @@ mc_cpu_callback(struct notifier_block *nb, unsigned long action, void *hcpu)
 	 * CPU comes back online without unnecessarily requesting the userspace
 	 * for it again.
 	 */
+	default:
+		break;
 	}
 
-	/* The CPU refused to come up during a system resume */
-	if (action == CPU_UP_CANCELED_FROZEN)
-		microcode_fini_cpu(cpu);
-
 	return NOTIFY_OK;
 }
 
-- 
2.0.0.rc2

Attachment: signature.asc
Description: Digital signature