Re: [PATCH v2] ASoC: wm8962: Let CODEC driver enable and disable its own MCLK

From: Mark Brown
Date: Mon Jul 28 2014 - 08:22:33 EST


On Mon, Jul 28, 2014 at 07:41:58PM +0800, Nicolin Chen wrote:

> + pdata->mclk = devm_clk_get(&i2c->dev, NULL);
> +

This is broken for deferred probe.

> + clk_prepare_enable(wm8962->pdata.mclk);
> +

Missing error checking.

Attachment: signature.asc
Description: Digital signature