Re: [PATCH v5] pcie: Add Xilinx PCIe Host Bridge IP driver
From: Arnd Bergmann
Date: Mon Jul 28 2014 - 09:03:16 EST
On Monday 28 July 2014 18:04:34 Srikanth Thokala wrote:
> Hi Arnd and Rob,
> I discussed with Bjorn and we believe this patch is in good shape to
> apply. And Bjorn requires ACKs to apply this patch. So, could you
> guys please review this patch and provided your ACKs to this patch.
Looks great for the most part. I've looked through the whole driver
again, and I have two small issues remaining:
a) Please clarify in the changeset description why there is no support
for PCI I/O space.
b) I think you should use the 'msi-parent' property, and the
of_pci_find_msi_chip_by_node() to find the msi_chip for the
PCI controller. This will make it possible to forward MSIs
to the main interrupt controller in the system, which is more
efficient. See the pcie-mvebu driver for an example of this.
Other than these:
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/