Re: [PATCH 1/1 linux-next] staging: ion: vm_insert_pfn and zap_page_range rely on CONFIG_MMU

From: Fabian Frederick
Date: Mon Jul 28 2014 - 09:56:14 EST




> On 25 July 2014 at 00:02 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> wrote:
>
>
> On Wed, Jul 23, 2014 at 09:04:38PM +0200, Fabian Frederick wrote:
> > Fix following sh-allmodconfig errors reported on kisskb
> > "
> > drivers/built-in.o: In function `ion_vm_fault':
> > ion.c:(.text+0x1f2d8f8): undefined reference to `vm_insert_pfn'
> > drivers/built-in.o: In function `ion_buffer_sync_for_device':
> > ion.c:(.text+0x1f316bc): undefined reference to `zap_page_range'
> > make: *** [vmlinux] Error 1
> > "
> >
> > Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
> > ---
> >
> > This is untested.
>
> I'd like to see it tested before I apply it...

Hello Greg,
   Â
    I did the following compilation tests:
   Â
    -sh/allyesconfig/cross-compile: no longer tries to compile ion with this
patch.
(MMU is only selected on !CPU_SH2 sub-type)

    -sh/SH-x3 subtype/cross-compile (->mmu on): compilation ok

    -x86_64 Compilation ok.
   Â
Do you need more testing ?

Regards,
Fabian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/