Re: [E1000-devel] [PATCH] net: ethernet: intel: ixgbe: ixgbe_main.c: Cleaning up missing null-terminate in conjunction with strncpy
From: Brown, Aaron F
Date: Tue Jul 29 2014 - 16:20:54 EST
On Tue, 2014-07-29 at 14:15 +0200, Rickard Strandqvist wrote:
> Den 29 jul 2014 04:40 skrev "Stephen Hemminger" <stephen@xxxxxxxxxxxxxxxxxx
> > On Sat, 26 Jul 2014 16:24:36 +0200
> > Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> wrote:
> > > Replacing strncpy with strlcpy to avoid strings that lacks null
> > >
> > > Signed-off-by: Rickard Strandqvist <
> > > ---
> > hw->mac.type, hw->phy.type, hw->phy.sfp_type,
> > This patch doesn't change anything.
> > Netdev is already zeroed when allocated therefore doing strncpy()
> > it will be null terminated.
> Hi Stephen
> It's not clear that alloc_etherdev_mq() will zero the memory area:
Thanks Rickard, given strncpy to strlcpy gets suggested by static code
generators this will probably come up again even if it results in no
real change. I (covering for Jeff Kirsher) went ahead and added it to
our internal tree.