Re: [PATCH] x86, efi: print debug values in Kib not MB

[Joe Perches]

On Tue, 2014-07-29 at 13:29 -0700, David Rientjes wrote:
> On Tue, 29 Jul 2014, Prarit Bhargava wrote:
> > diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
[]
> > @@ -384,10 +384,10 @@ static void __init print_efi_memmap(void)
> >  	     p < memmap.map_end;
> >  	     p += memmap.desc_size, i++) {
> >  		md = p;
> > -		pr_info("mem%02u: type=%u, attr=0x%llx, range=[0x%016llx-0x%016llx) (%lluMB)\n",
> > +		pr_info("mem%02u: type=%u, attr=0x%llx, range=[0x%016llx-0x%016llx) (%lluKiB)\n",
> >  			i, md->type, md->attribute, md->phys_addr,
> >  			md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT),
> > -			(md->num_pages >> (20 - EFI_PAGE_SHIFT)));
> > +			(md->num_pages << 2));
> >  	}
> >  #endif  /*  EFI_DEBUG  */
> >  }
> 
> If EFI_PAGE_SHIFT were to ever change from its hard-coded 12, then( this 
> would be wrong.  Any reason to not simply print EFI_PAGE_SIZE and 
> md->num_pages?

Or maybe ((u64)EFI_PAGE_SIZE * md->num_pages) >> 10


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/