Re: [PATCH] x86, efi: print debug values in Kib not MB

[Borislav Petkov]

On Tue, Jul 29, 2014 at 01:09:21PM -0400, Prarit Bhargava wrote:
> The current debug print in EFI does
> 
> [    0.000000] efi: mem84: type=3, attr=0xf, range=[0x00000000645b5000-0x00000000645fb000) (0MB)
> 
> and rounds off the size to 0MB and isn't very useful.  We should print this in
> Kib.  After applying this patch we get better info with
> 
> [    0.000000] efi: mem84: type=3, attr=0xf, range=[0x00000000645b5000-0x00000000645fb000) (280kiB)

Turning this into kiB unconditionally won't always work ok:

First of all, there might be something which parses that output so I'd
make sure I'm not breaking that. Maybe fwts... Matt will know.

Then, I have an UEFI region which is > 13G:

[    0.000000] efi: mem42: type=7, attr=0xf, range=[0x0000000100000000-0x0000000450000000) (13568MB)


With your patch it is even worse:

[    0.000000] efi: mem42: type=7, attr=0xf, range=[0x0000000100000000-0x0000000450000000) (13893632kiB)


I'd guess you'll have to go all out and do this properly. :-)

Something like showing the highest unit which is still > 1. In the above
case, this should be (13GB) or maybe even introduce fractions.

Depends on how involved this output should be.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/