Re: [PATCH] net: irda: delete double assignment
From: David Miller
Date: Tue Jul 29 2014 - 18:47:13 EST
From: Himangi Saraogi <himangi774@xxxxxxxxx>
Date: Mon, 28 Jul 2014 20:58:12 +0530
> @@ -621,7 +621,6 @@ void irlap_send_rd_frame(struct irlap_cb *self)
> frame = (struct rd_frame *)skb_put(tx_skb, 2);
> - frame->caddr = self->caddr;
> frame->caddr = RD_RSP | PF_BIT;
This doesn't look correct to me.
I think both lines should be kept, and the second line should be
changed to assign those bits to frame->control.
This is consistent with other parts of the file that make use of the PF_BIT.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/