Re: [PATCH] x86, efi: print debug values in Kib not MB

[Prarit Bhargava]

On 07/29/2014 06:36 PM, Borislav Petkov wrote:
> On Tue, Jul 29, 2014 at 06:32:56PM -0400, Prarit Bhargava wrote:
>> and it was best to keep the code simple with a KiB.
> 
> You're missing the point - the output doesn't get simple with KiB. Read
> the example I just gave you!
> 
> (13893632kiB) is actively *not* helping when one looks at it!

I did get your point and I'm (politely) disagreeing with it.  Your case ONLY
works if the number is _exactly_ 13GB.  What if it is 13.5?  Then we're still
rounding off and reporting 14GB.  Which, if this code is meant for debug, makes
no sense to me.  Why round it off?

P.

> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/