Re: [RFC/PATCH] perf tools: Check recorded kernel version when finding vmlinux

[Namhyung Kim]

Hi David,

On Tue, 29 Jul 2014 09:14:54 -0600, David Ahern wrote:
> On 7/29/14, 2:15 AM, Namhyung Kim wrote:
>> This requires to change signature of symbol__init() to receive struct
>> perf_session_env *.  This patch only does some trivial changes - some
>
> Why only pass the env for perf-report? Why not for any command
> analyzing a file? So for live commands env is NULL meaning use host
> paths; for recorded files pass env from session header and use it
> (plus symbol settings like symfs).

Yes, it needs other changes like you said.  But I'd like to hear from
your opinions on the problem and proposed fix before going further.

My other concern is that why it isn't covered by a build-id cache.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/