Re: [PATCH v5 2/7] crypto: SHA1 multibuffer crypto hash infrastructure

From: Peter Zijlstra
Date: Wed Jul 30 2014 - 06:02:08 EST


On Tue, Jul 29, 2014 at 03:28:25PM -0700, Tim Chen wrote:
> Peter,
>
> Is my explanation adequate or you still have objection to the implementation? I'm
> trying to decide here whether to extend our batch processing by
> the crypto daemon (prolong our busy period)
> based on whether there are other tasks to run. Pre-emption and
> resuming the crypto daemon is okay. Even if there's a pre-emption and
> context switch in between, we can still do extended processing if
> there's nothing else to run. Otherwise the cpu will go idle.

I suppose.. I still don't really like it but what the heck.

That single_task_running thing is hard to use and a weird interface so
lets hope people don't find more 'creative' users for it.


Attachment: pgpKNFZkr8IUx.pgp
Description: PGP signature