Re: [PATCH v2 1/1] staging: vt6655: ioctl.c - missing __user annotation

From: Tobias Klauser
Date: Wed Jul 30 2014 - 07:32:56 EST

On 2014-07-30 at 12:41:59 +0200, Anil Belur <askb23@xxxxxxxxx> wrote:
> From: Anil Belur <askb23@xxxxxxxxx>

This line is only necessary if you're sending the patch on behalf of
someone else. Also there is no need to have the 1/1 in the Subject line
as you're only sending one patch, not an entire series.

> v2:
> - private_ioctl() internally calls copy_{to,from}_user() and does
> not use '__user' which gives out several sparse warnings
> - this patch adds __user annotation to the data member of struct
> tagSCmdRequest as suggested by tklauser@xxxxxxxxxx

Patch history should go below the '---' as it doesn't need to be
included in the commit message.

> - sparse warnings fixed:
> drivers/staging/vt6655/ioctl.c:78:51: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/ioctl.c:78:51: expected void const [noderef] asn:1>*from
> drivers/staging/vt6655/ioctl.c:78:51: got void *data

It's sufficient to only show one instance of the sparse warning in the
commit message, since they're all the same.

> drivers/staging/vt6655/ioctl.c:117:55: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/ioctl.c:117:55: expected void const [noderef] asn:1>*from
> drivers/staging/vt6655/ioctl.c:117:55: got void *data
> drivers/staging/vt6655/ioctl.c:149:46: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/ioctl.c:149:46: expected void [noderef] asn:1>*to
> drivers/staging/vt6655/ioctl.c:149:46: got void *data
> drivers/staging/vt6655/ioctl.c:166:51: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/ioctl.c:166:51: expected void const [noderef] asn:1>*from
> drivers/staging/vt6655/ioctl.c:166:51: got void *data
> drivers/staging/vt6655/ioctl.c:212:50: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/ioctl.c:212:50: expected void const [noderef] asn:1>*from
> drivers/staging/vt6655/ioctl.c:212:50: got void *data
> drivers/staging/vt6655/ioctl.c:276:38: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/ioctl.c:276:38: expected void [noderef] asn:1>*to
> drivers/staging/vt6655/ioctl.c:276:38: got void *data
> drivers/staging/vt6655/ioctl.c:292:38: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/ioctl.c:292:38: expected void [noderef] asn:1>*to
> drivers/staging/vt6655/ioctl.c:292:38: got void *data
> drivers/staging/vt6655/ioctl.c:300:48: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/ioctl.c:300:48: expected void const [noderef] asn:1>*from
> drivers/staging/vt6655/ioctl.c:300:48: got void *data
> drivers/staging/vt6655/ioctl.c:344:38: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/ioctl.c:344:38: expected void [noderef] asn:1>*to
> drivers/staging/vt6655/ioctl.c:344:38: got void *data
> drivers/staging/vt6655/ioctl.c:353:38: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/ioctl.c:353:38: expected void [noderef] asn:1>*to
> drivers/staging/vt6655/ioctl.c:353:38: got void *data
> drivers/staging/vt6655/ioctl.c:360:38: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/ioctl.c:360:38: expected void [noderef] asn:1>*to
> drivers/staging/vt6655/ioctl.c:360:38: got void *data
> drivers/staging/vt6655/ioctl.c:401:49: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/ioctl.c:401:49: expected void const [noderef] asn:1>*from
> drivers/staging/vt6655/ioctl.c:401:49: got void *data
> drivers/staging/vt6655/ioctl.c:424:49: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/ioctl.c:424:49: expected void const [noderef] asn:1>*from
> drivers/staging/vt6655/ioctl.c:424:49: got void *data
> drivers/staging/vt6655/ioctl.c:440:49: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/ioctl.c:440:49: expected void const [noderef] asn:1>*from
> drivers/staging/vt6655/ioctl.c:440:49: got void *data
> drivers/staging/vt6655/ioctl.c:457:49: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/ioctl.c:457:49: expected void const [noderef] asn:1>*from
> drivers/staging/vt6655/ioctl.c:457:49: got void *data
> drivers/staging/vt6655/ioctl.c:479:54: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/ioctl.c:479:54: expected void const [noderef] asn:1>*from
> drivers/staging/vt6655/ioctl.c:479:54: got void *data
> drivers/staging/vt6655/ioctl.c:563:38: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/ioctl.c:563:38: expected void [noderef] asn:1>*to
> drivers/staging/vt6655/ioctl.c:563:38: got void *data
> drivers/staging/vt6655/ioctl.c:571:52: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/ioctl.c:571:52: expected void const [noderef] asn:1>*from
> drivers/staging/vt6655/ioctl.c:571:52: got void *data
> drivers/staging/vt6655/ioctl.c:615:38: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/ioctl.c:615:38: expected void [noderef] asn:1>*to
> drivers/staging/vt6655/ioctl.c:615:38: got void *data
> drivers/staging/vt6655/ioctl.c:631:53: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/ioctl.c:631:53: expected void const [noderef] asn:1>*from
> drivers/staging/vt6655/ioctl.c:631:53: got void *data
>
> Signed-off-by: Anil Belur <askb23@xxxxxxxxx>
> ---
> drivers/staging/vt6655/iocmd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/iocmd.h b/drivers/staging/vt6655/iocmd.h
> index e499f1b..dd12498 100644
> --- a/drivers/staging/vt6655/iocmd.h
> +++ b/drivers/staging/vt6655/iocmd.h
> @@ -100,7 +100,7 @@ typedef enum tagWZONETYPE {
> #pragma pack(1)
> typedef struct tagSCmdRequest {
> u8 name[16];
> - void *data;
> + void __user *data;
> u16 wResult;
> u16 wCmdCode;
> } SCmdRequest, *PSCmdRequest;
> --
> 1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/