Re: [PATCH] Staging: vt6655: staticfy variable

[Greg KH]

On Wed, Jul 30, 2014 at 11:20:49PM +0200, Fernando Apesteguía wrote:
> On Wed, Jul 30, 2014 at 9:16 PM, Guillaume Clement <gclement@xxxxxxxxxx> wrote:
> > Hello,
> >
> >> Add static to variable.
> >> Signed-off-by: Fernando Apesteguia <fernando.apesteguia@xxxxxxxxx>
> >> ---
> >>  drivers/staging/vt6655/ioctl.c |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/vt6655/ioctl.c
> >> b/drivers/staging/vt6655/ioctl.c
> >> index 65e5933..cc6e47b 100644
> >> --- a/drivers/staging/vt6655/ioctl.c
> >> +++ b/drivers/staging/vt6655/ioctl.c
> >> @@ -41,7 +41,7 @@
> >>  static int msglevel = MSG_LEVEL_INFO;
> >>
> >>  #ifdef WPA_SM_Transtatus
> >> -SWPAResult wpa_Result;
> >> +static SWPAResult wpa_Result;
> >>  #endif
> >
> > This changes breaks the compilation (actually the linking). wpa_Result
> > is actually used in device_main.c in device_open with the following:
> 
> Argh... sorry, I missed that.

ALWAYS test-build your patches, don't make me be your first tester...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/