Re: [PATCH v8 11/11] drm: sti: Add DRM driver itself

[Benjamin Gaignard]

It is a regression that I have introduce with universal plane.
I have fix it and refresh v8 branch.

I have map CRTC on hardware mixers IP.
I could have one or two mixers, its depends of the chipset and I use
one graphic input (GDP) per mixer as primary plane.
Other GPD are used as overlay planes.
Some version of the display IP have one hardware cursor which could be
used only with the first mixer.

I haven't push yet the code to support the cursor, I would like to do
it when the current patches will have been accepted and merge
upstream.


2014-07-30 23:04 GMT+02:00 Rob Clark <robdclark@xxxxxxxxx>:
> On Wed, Jul 30, 2014 at 3:48 PM, Daniel Vetter <daniel@xxxxxxxx> wrote:
>> On Wed, Jul 30, 2014 at 7:42 PM, Benjamin Gaignard
>> <benjamin.gaignard@xxxxxxxxxx> wrote:
>>> @@ -87,11 +90,50 @@ static int sti_compositor_bind(struct device *dev, struct device *master,
>>>         struct sti_compositor *compo = dev_get_drvdata(dev);
>>>         struct drm_device *drm_dev = data;
>>>         unsigned int i, crtc = 0, plane = 0;
>>> +       struct sti_drm_private *dev_priv = drm_dev->dev_private;
>>> +       struct drm_plane *cursor = NULL;
>>> +       struct drm_plane *primary = NULL;
>>> +
>>> +       dev_priv->compo = compo;
>>>
>>>         drm_vblank_init(drm_dev, crtc);
>>
>>
>> This looks strange - you should pass this the total number of crtcs
>> (the same that eventually ends up in dev->mode_config.num_crtc), not
>> 0. And the assignement of cursors to crtcs looks a bit strange on
>
> hmm, Benjamin probably should try modetest w/ -v arg..  it does look a
> bit like something is missing here..
>
> BR,
> -R
>
>> first read-through, but I have no clue about the sti hw. And in any
>> case those pointers really only matter for backwards compat with
>> existing pageflip and cursor ioctls, so doesn't really matter too
>> much.
>>
>> Anyway didn't spot anything else which would need to be upgrade to
>> never kms interfaces, so ack from my side for that. Only looked at
>> that since right now I'm refreshing drm docs in those areas ;-)
>> -Daniel
>> --
>> Daniel Vetter
>> Software Engineer, Intel Corporation
>> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@xxxxxxxxxxxxxxxxxxxxx
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel



-- 
Benjamin Gaignard

Graphic Working Group

Linaro.org â Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/