Re: [PATCH v3 4/4] ARM: dts: Add exynos5250-spring device tree

[Ajay kumar]

Hi Andreas,

On Thu, Jul 31, 2014 at 2:56 PM, Andreas FÃrber <afaerber@xxxxxxx> wrote:
> Am 30.07.2014 15:50, schrieb Andreas FÃrber:
>> diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts
>> new file mode 100644
>> index 000000000000..bcca892bf2ff
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/exynos5250-spring.dts
> [...]
>> +&pinctrl_0 {
>> +     dp_hpd_gpio: dp-hpd-gpio {
>> +             samsung,pins = "gpc3-0";
>> +             samsung,pin-function = <1>;
>
> Not sure where this 1 came from... Both Ajay and my 3.8 DT have 0.
Right, this should be 0.

>> +             samsung,pin-pud = <3>;
>> +             samsung,pin-drv = <0>;
>> +     };
>
> Seeing that Ajay called this node dp-hdp, it should probably be an override?
dp_hpd should be enough. I will keep the same name for peach boards.
dp_hpd: dp-hpd {
.
.
.
};

Ajay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/