[PATCH] gpiolib: Don't allow drivers to specify a base with DT

From: Mark Brown
Date: Thu Jul 31 2014 - 08:08:07 EST

From: Mark Brown <broonie@xxxxxxxxxx>

DT based systems should have no reason to use fixed GPIO numbers but some
drivers that work on both DT and non-DT platforms specify them anyway. In
order to improve robustness in cases where drivers use gpio_is_valid() to
check for a valid GPIO on data initialized to zero as a default and avoid
bugs due to assuptions about fixed numbers creeping in ignore any specified
base when DT is in use.

Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
drivers/gpio/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 768f0831db18..11d3cf1cbca7 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -234,7 +234,7 @@ int gpiochip_add(struct gpio_chip *chip)

spin_lock_irqsave(&gpio_lock, flags);

- if (base < 0) {
+ if (base < 0 || of_have_populated_dt()) {
base = gpiochip_find_base(chip->ngpio);
if (base < 0) {
status = base;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/