Re: [PATCH 2/5] char: tile-srom: Remove reference to platform_bus

From: Chris Metcalf
Date: Thu Jul 31 2014 - 16:24:43 EST


On 7/25/2014 10:23 AM, Pawel Moll wrote:
The code was creating "srom" class devices using
platform_bus as a parent. As they are not really
platform devices, make them virtual, using NULL instead.

Cc: Chris Metcalf<cmetcalf@xxxxxxxxxx>
Signed-off-by: Pawel Moll<pawel.moll@xxxxxxx>
---
drivers/char/tile-srom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Can you clarify the point of this change a bit? The SROM devices
in question are real devices (bits of silicon on the processor die), not
some kind of virtual construct. In addition, we also have user binaries
in the wild that know to look for /sys/devices/platform/srom/ paths,
so I'm pretty reluctant to change this path without good reason.

--
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/