Re: [U-Boot] [PATCH] kconfig: Fix compiler warning in menu.c

From: Jeroen Hofstee
Date: Thu Jul 31 2014 - 18:21:52 EST

Hello Hans,

On 31-07-14 16:21, Hans de Goede wrote:
This fixes the following compiler warning:

In file included from scripts/kconfig/
scripts/kconfig/menu.c: In function âget_symbol_strâ:
scripts/kconfig/menu.c:590:18: warning: âjumpâ may be used uninitialized in this function [-Wmaybe-uninitialized]
jump->offset = strlen(r->s);
In file included from scripts/kconfig/
scripts/kconfig/menu.c:551:19: note: âjumpâ was declared here
struct jump_key *jump;

Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
scripts/kconfig/menu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index a26cc5d..584e0fc 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
int i, j;
struct menu *submenu[8], *menu, *location = NULL;
- struct jump_key *jump;
+ struct jump_key *jump = NULL;
str_printf(r, _("Prompt: %s\n"), _(prop->text));
menu = prop->menu->parent;

And if you combine head && location into a single boolean,
does this warning still occur? Not that it matters that much
in this case, since it is a host tool, but I guess the compiler
does intend to assign NULL while there is no reason to do so.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at