Re: [PATCH 2/5] raid: Require designated initialization of structures

From: Josh Triplett
Date: Thu Jul 31 2014 - 21:30:49 EST


On Fri, Aug 01, 2014 at 11:10:55AM +1000, NeilBrown wrote:
> On Thu, 31 Jul 2014 16:47:35 -0700 Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> wrote:
>
> > Mark raid6_calls and other structures containing function pointers with
> > __designated_init. Fix implementations in lib/raid6/ to use designated
> > initializers; this also simplifies those initializers using the default
> > initialization of fields to 0.
> >
> > Signed-off-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
>
> Looks like an excellent idea!
> Feel free to forward this upstream on my behalf, or remind me once the first
> patch is in -next, and I'll take this one myself - whichever you prefer.
>
> Acked-by: NeilBrown <neilb@xxxxxxx>

Thanks! Ideally, I'd like to see the whole series go in through one
tree, which is why I CCed Andrew. I can easily produce several dozen
more patches like these, but I just included enough examples to motivate
patch 1, and I can send more in any order once that one goes in.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/