Re: [patch 2/3] mm, oom: remove unnecessary check for NULL zonelist

From: David Rientjes
Date: Fri Aug 01 2014 - 05:10:47 EST


On Thu, 31 Jul 2014, Johannes Weiner wrote:

> out_of_memory() wants the zonelist that was used during allocation,
> not just the random first node's zonelist that's simply picked to
> serialize page fault OOM kills system-wide.
>
> This would even change how panic_on_oom behaves for page fault OOMs
> (in a completely unpredictable way) if we get CONSTRAINED_CPUSET.
>
> This change makes no sense to me.
>

Allocations during fault will be constrained by the cpuset's mems, if we
are oom then why would we panic when panic_on_oom == 1?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/