Re: [PATCH 29/35] arm: omap: intc: switch over to linear irq domain
From: Felipe Balbi
Date: Fri Aug 01 2014 - 09:55:19 EST
Hi,
On Fri, Aug 01, 2014 at 03:26:34PM +0300, Tero Kristo wrote:
> >>>>>>I might have sent the wrong version as I had that same build error and
> >>>>>>fixed it localy.
> >>>>>>
> >>>>>>>it fixes the regression for me, Also now the whole series works for
> >>>>>>>me :)
> >>>>>>
> >>>>>>good to know.
> >>>>>>
> >>>>>>What do you want to do now ? Wait for PRCM to become a driver ? Wait for
> >>>>>>Nishanth's series to get accepted ? I guess the same thing could be done
> >>>>>>for OMAP3 and AM33, then we would have a chance of having working wake
> >>>>>>from idle with the new irqchip.
> >>>>>
> >>>>>I can repost the current series as it stands now once 17-rc1 comes out
> >>>>>(without the build failure ofcourse).. if that helps to move it out of
> >>>>>RFC status.
> >>>>
> >>>>That'd be great. It would be ever greater if you could add support for
> >>>>OMAP3 on that too.
> >>>
> >>>Yeah sounds good to me. Tero, does that work OK for your PRCM changes?
> >>
> >>Well, this set seems to break PM. suspend-resume on omap3-beagle just hangs
> >>after this set is applied. Works fine without it with 3.16-rc5 tag.
> >
> >did you apply the quick little hack to prm3xxx.c ? prcm IRQ is hardcoded
> >to 11, once we switch to a linear irq domain, irq_base may change.
>
> Yea, with that hack it works. However, you should make that into a proper
> patch and add it to this series, otherwise you will be causing regressions.
can you please read the thread ? Nishanth has a proper series properly
doing that for OMAP4, I asking him to add OMAP3 and respin his series
without RFC.
--
balbi
Attachment:
signature.asc
Description: Digital signature