Re: [PATCHv10 4/4] dt: mailbox: add generic bindings

From: Mark Brown
Date: Fri Aug 01 2014 - 14:43:37 EST


On Fri, Aug 01, 2014 at 06:02:45PM +0530, Jassi Brar wrote:

> +Optional property:
> +- mbox-names: List of identifier strings for each mailbox channel
> + required by the client. The use of this property
> + is discouraged in favor of using index in list of
> + 'mboxes' while requesting a mailbox.

Can I suggest that if we do want to avoid strings for some reason (it's
not obvious to me why) then we include a recommendation to provide
defines in a header file in order to improve legibility. That's pretty
minor, though.

Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>

Attachment: signature.asc
Description: Digital signature