Re: [PATCH v1.3 4/18] arcmsr: limit max. number of SCSI command request

[Ching Huang]

On Fri, 2014-08-01 at 05:35 -0700, Christoph Hellwig wrote:
> > @@ -2220,8 +2220,7 @@ static int arcmsr_queue_command_lck(stru
> >  		arcmsr_handle_virtual_command(acb, cmd);
> >  		return 0;
> >  	}
> > -	if (atomic_read(&acb->ccboutstandingcount) >=
> > -			ARCMSR_MAX_OUTSTANDING_CMD)
> > +	if (atomic_read(&acb->ccboutstandingcount) >= acb->maxOutstanding)
> >  		return SCSI_MLQUEUE_HOST_BUSY;
> 
> The scsi midlayer already takes care of this check for you.
> 

Hello Christoph,

We have 4 types of Adapter that some adpaters have command queue less
than ARCMSR_MAX_OUTSTANDING_CMD.
So we have to check outstanding command number here.

Thanks for your comment.
Ching

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/