Re: [PATCH 2/2] dma: imx-sdma: Adding tasklet_kill() in sdma_remove function.

From: Vignesh Raman
Date: Mon Aug 04 2014 - 04:35:12 EST


On Friday 01 August 2014 10:15 PM, Vinod Koul wrote:
> On Fri, Aug 01, 2014 at 07:36:53PM +0530, Vignesh Raman wrote:
>> On Thursday 31 July 2014 05:32 PM, Vinod Koul wrote:
>>> On Wed, Jul 30, 2014 at 06:41:15PM +0530, Vignesh Raman wrote:
>>>> Several dma drivers calls tasklet_kill() in remove function. This is missing in
>>>> imx driver, so adding tasklet_kill() in sdma_remove function.
>>> And why should we do that ?
>>>
>> This is done because all running tasklets should be killed on remove.
>
> And what prevents is from mentioning this in changelog!
>

I should have mentioned in the Changelog but missed it, sorry about
that. I will add it and send updated version.

Regards,
Vignesh.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/