Re: [PATCH 4/4] Return the fan speed via sysfs

[Jean Delvare]

Le Sunday 03 August 2014 Ã 18:42 +0200, Goffredo Baroncelli a Ãcrit :
> On 08/03/2014 05:59 PM, Jean Delvare wrote:
> > The temperature attributes in hwmon would need different names and
> > units too (temp1_input and temp2_input, in millidegree C.) The
> > advantage is that all monitoring applications out there would pick up
> > these values automatically.
> 
> Are you suggesting to add also a "temp1_input" attribute ?

Yes, but as a hwmon class device attribute, not as an attribute
in /sys/devices/temperature.

> >> I even thought to allow to change the fan speed from user space....
> > 
> > Ben will never let you do that ;-)
> 
> What would be the risk ?. When the CPU temperature goes behind the limit, 
> then the computer is switched off by an hardware protection (I am sure because
> I had to changed a cpu board because a drift of the temperature sensor).

And you are still asking what the risk is? ;-)

> I am not suggesting to allow to change the fan speed, I am only asking which would
> be the risk.

If the user forces the fan too low, the system can overheat, and that
can result in user injury or hardware damage (or reduced lifetime of
hardware, at least.)

Some people think that the user should always be given full power over
his/her hardware. Others think that hardware should just work and users
should never have to care about such low-level details.

In this specific case I'd say don't change it unless you have a
compelling reason to.

-- 
Jean Delvare
SUSE L3 Support

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/