Re: [PATCH 00/18] staging: comedi: amplc_pci224: remove legacy stuff

[Ian Abbott]

On 2014-07-31 21:28, Hartley Sweeten wrote:
> On Thursday, July 31, 2014 6:48 AM, Ian Abbott wrote:
> > The "amplc_pci224" driver retains a "legacy" attach mechanism via the
> > `COMEDI_DEVCONFIG` ioctl and the comedi driver "attach" hook, but
> > usually attaches PCI devices automatically via the comedi driver's
> > "auto_attach" hook.  The legacy mechanism is only retained so that
> > options can be passed via the ioctl to indicate how some hardware
> > jumpers are set on the boards, which is used to set up the range tables.
> > That's no use if the PCI device is attached automatically as the range
> > tables will be set up according to the factory default jumper positions.
> >
> > Change the range tables to include all possible ranges, regardless of
> > jumper positions.  Then there is no need to have options to control
> > setting up the range tables and the "legacy" attach mechanism can be
> > removed.
> >
> > Also, tidy the code up a bit.
>
> Looks good.
>
> Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
>
> Side note:
>
> Now that the manual attach has been removed, you could also remove
> the board information from the comedi_driver declaration.

Good point.  I can do that as a follow-up patch.  It only affects the 
output of /proc/comedi I think.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/