Re: [PATCH] jffs2: Re-enable write-buffering after filesystem sync

From: Jeff Harris
Date: Mon Aug 04 2014 - 14:02:35 EST


On Fri, Aug 1, 2014 at 3:13 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> Why do we need ->wbuf_queued, anyway? It's not as if queue_delayed_work()
> wouldn't do the right thing - if the sucker already has WORK_STRUCT_PENDING_BIT
> set it'll simply do nothing. And it won't spend much time finding that
> out - in fact, it'll be cheaper than what we do right now.
>
> IOW, how about the following (completely untested):
>

I tested the patch against our 3.13 device, and it appears to resolve
the original
write-buffering after sync problem we were having. I did not do any
other regression
testing, though.

Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/