Re: [PATCH 2/2 v2] serial: Add support for Fintek F81216A LPC to 4 UART

[One Thousand Gnomes]

On Fri, 1 Aug 2014 14:28:11 +0200
Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx> wrote:

> Hello
> 
> >> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx>
> >
> > This half of things looks good to me.
> 
> 
> Thanks!, What about the other half? Would you accept a two step approach?
> 
> 1st: add support for 8250_core
> 2nd: handle rs485 ioctl on serial_core and modify all the other
> drivers to use that? (to avoid code duplication)

We really want to handle it at the tty layer I think not at serial_core.
I have a patch for that and I'm playing with it but it's taking longer
than I hoped.

In the mean time I think your patch #1 is ok except for the trivial
item that I'd prefer the struct serial_rs485 was further down the struct
uart_8250_port. It's packed so that the bits you need most are in the
first cache line or two.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/