Re: [PATCH RESEND] usb: ehci/ohci-exynos: Fix PHY getting sequence

From: Vivek Gautam
Date: Tue Aug 05 2014 - 07:48:17 EST


Hi Jingoo,


On Tuesday, August 05, 2014 4:28 PM, Jingoo Han wrote:
On Tuesday, August 05, 2014 7:39 PM, Vivek Gautam wrote:

Since we want to keep support for both older usb-phys as well as the
newer generic phys, lets first get the generic PHYs and fallback to
older USB-PHYs only when we fail to get the former.
This should fix the issue with ehci-exynos and ohci-exynos, wherein
in the absence of SAMSUNG_USB2PHY config symbol, we end up getting
the NOP_USB_XCEIV phy when the same is enabled. And thus the PHYs
are not configured properly.

Reported-by: Sachin Kamat <sachin.kamat@xxxxxxxxxxx>
Signed-off-by: Vivek Gautam <gautam.vivek@xxxxxxxxxxx>
Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
Cc: Jingoo Han <jg1.han@xxxxxxxxxxx>

Acked-by: Jingoo Han <jg1.han@xxxxxxxxxxx>

Right, we would get the generic PHYs first, then get the older
usb-phys. Then, the older one will be removed from the kernel.

Right, I have a set of patches to remove the older phy support for Exynos SoC series,
keeping the support for S3C64XX, which I shall send soon.

[snip]

Thanks
Vivek Gautam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/