Re: [PATCH] arch/powerpc/mm/numa.c: Fix break placement

[Michael Ellerman]

On Tue, 2014-08-05 at 19:16 +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2014-08-04 at 23:13 +0300, Andrey Utkin wrote:
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=81631
> > Reported-by: David Binderman <dcb314@xxxxxxxxxxx>
> > Signed-off-by: Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx>
> 
> Thanks, I wonder how that managed to remain unnoticed for so long !

1. No one tested it :)
2. The code stupidly initialises ret at the beginning of the function, so the
   compiler can't help us detect the unitialised usage.
3. NOTIFY_OK and NOTIFY_DONE appear to be equivalent in practice.

cheers



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/