Re: [RFC PATCH 03/11] PCI/MSI: Refactor pci_dev_msi_enabled()
From: Yijing Wang
Date: Tue Aug 05 2014 - 21:24:54 EST
On 2014/8/6 6:35, Stuart Yoder wrote:
> On Fri, Jul 25, 2014 at 10:08 PM, Yijing Wang <wangyijing@xxxxxxxxxx> wrote:
>> Pci_dev_msi_enabled() is used to check whether device
>> MSI/MSIX enabled. Refactor this function to suuport
>> checking only device MSI or MSIX enabled.
>>
>> Signed-off-by: Yijing Wang <wangyijing@xxxxxxxxxx>
>
> So this patch refactors things so that checks like this:
> > - if (!dev->msi_enabled)
>
> are moved into a function:
> > + if (!pci_dev_msi_enabled(dev, MSI_TYPE))
>
> Can you explain a bit more why this needed. Is it just cleanup?
Hi Stuart, it's not just cleanup, because "[RFC PATCH 08/11] PCI/MSI: Introduce new struct msi_irqs and struct msi_ops"
introduced struct msi_irqs, so the code will change to
if (!dev->msi_irqs->msi_enabled)
I think driver should not need to know the details of MSI members.
So I try to rework the pci_dev_msi_enabled() to hide the detailed MSI info.
Thanks!
Yijing.
>
> .
>
--
Thanks!
Yijing
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/